Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL: add list and map types #351

Merged
merged 1 commit into from
Mar 31, 2019
Merged

DSL: add list and map types #351

merged 1 commit into from
Mar 31, 2019

Conversation

cesarblum
Copy link

@cesarblum cesarblum commented Mar 31, 2019

Addresses #337

Can now do

data MyData {
  list<string> aList;
  map<string, int32> aMap;
}

And

actor MyActor {
  map<string, int32> aMethod(list<int64> arg);
}

Works with user-defined types as well, and can be nested (e.g. list<map<string, list<int32>>>).

Very rudimentary support with essentially no validation for now. I'll add validation in a subsequent PR.

@JoeHegarty JoeHegarty added the dsl label Mar 31, 2019
Copy link

@victorhurdugaci victorhurdugaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few comments but nothing critical

@cesarblum cesarblum merged commit 830aed4 into next Mar 31, 2019
@cesarblum cesarblum deleted the dsl/collection-types branch March 31, 2019 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants