Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Message Import Improvements #7

Merged
merged 2 commits into from
Nov 13, 2018

Conversation

davidbartonau
Copy link
Contributor

Some improvements for overlength messages. My comment also says I redid @heuri fix, but repulling made that comment invalid.

@ylluminarious
Copy link
Contributor

@davidbartonau Sorry for the delayed response. It's been a somewhat hectic past few days. I don't have time to test this right now, but I trust that you already did so I'm going to go ahead and merge. Everything looks okay to me... ping @gabrielrios in case you want to take a look.

Also, we tend to use under_scores instead of camelCase. But it's not a big deal; I'm just telling you for future reference. We probably should have some sort of style file, so it's really our own fault.

Lastly: thank you so much for the contribution! We appreciate it!

@ylluminarious ylluminarious merged commit d887295 into orbitalimpact:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants