Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: verifier data to buffer #26
This fixes an issue where verifying an identity in an entry fails right now
The signing in the identity provider passes id as data - https://github.com/orbitdb/orbit-db-identity-provider/blob/master/src/identities.js#L52
But is converted to a buffer here - https://github.com/orbitdb/orbit-db-keystore/blob/master/src/keystore.js#L178
While the verifier in the identity provider is passed id as data - https://github.com/orbitdb/orbit-db-identity-provider/blob/master/src/identities.js#L60
It isn't converted to a buffer, thus the verification fails.
Decide to add fix here, since coerced to buffer in sign function here, but could also make the fix in the identity provider if that made more sense for any reason.
Note: doesn't show up in current release since verifyIdentity not used in IPFS AC (looked like IPFS AC is the default still) - related here