Skip to content
This repository has been archived by the owner on Sep 30, 2023. It is now read-only.

fix: verifier data to buffer #26

Merged
merged 1 commit into from
May 9, 2019

Conversation

zachferland
Copy link
Contributor

This fixes an issue where verifying an identity in an entry fails right now

The signing in the identity provider passes id as data - https://github.com/orbitdb/orbit-db-identity-provider/blob/master/src/identities.js#L52

But is converted to a buffer here - https://github.com/orbitdb/orbit-db-keystore/blob/master/src/keystore.js#L178

While the verifier in the identity provider is passed id as data - https://github.com/orbitdb/orbit-db-identity-provider/blob/master/src/identities.js#L60

It isn't converted to a buffer, thus the verification fails.

Decide to add fix here, since coerced to buffer in sign function here, but could also make the fix in the identity provider if that made more sense for any reason.

Note: doesn't show up in current release since verifyIdentity not used in IPFS AC (looked like IPFS AC is the default still) - related here
https://github.com/orbitdb/orbit-db-access-controllers/pull/31/files

@shamb0t
Copy link
Contributor

shamb0t commented May 9, 2019

Thank you @zachferland! I think you're right that this makes more sense here than in the identity-provider, happy to merge it as is

@shamb0t shamb0t merged commit 4d6c4c5 into orbitdb-archive:master May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants