This repository has been archived by the owner on Sep 30, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where verifying an identity in an entry fails right now
The signing in the identity provider passes id as data - https://github.com/orbitdb/orbit-db-identity-provider/blob/master/src/identities.js#L52
But is converted to a buffer here - https://github.com/orbitdb/orbit-db-keystore/blob/master/src/keystore.js#L178
While the verifier in the identity provider is passed id as data - https://github.com/orbitdb/orbit-db-identity-provider/blob/master/src/identities.js#L60
It isn't converted to a buffer, thus the verification fails.
Decide to add fix here, since coerced to buffer in sign function here, but could also make the fix in the identity provider if that made more sense for any reason.
Note: doesn't show up in current release since verifyIdentity not used in IPFS AC (looked like IPFS AC is the default still) - related here
https://github.com/orbitdb/orbit-db-access-controllers/pull/31/files