redirections #10

patte · 2018-01-04T00:08:55Z

affects: @orbiting/backend-modules-redirections

TODOs:

slug change -> redirection -> slug change back to original -> only keep second change back to original

affects: @orbiting/backend-modules-redirections

patte · 2018-01-04T20:45:17Z

@tpreusse I'm against naming the graphql query / type Resource. You get back a source and target, so it's a redirection between resources or a pointer to a resource but no a resource as such. Maybe I get your point when I can read it.
According return-nothing vs. return always with status 404 I'm open.

tpreusse · 2018-01-04T21:35:48Z

@patte I agree that it doesn't make sense—here—in a redirection module. But it would make sense in republik-backend: (find)resource(path: String) would give the backend the power to get its hand on any unmatched path, try to find the entity and respond with the correct status (503—upstream backend down, 410—get ride of it forever, 404—not found, redirects etc.). It can only be the backend which is aware of everything not some module that only know where little about the world. I'd recommend to only collect the lib utils for redirection in this module and do the graph ql endpoint as resource in republik-backend. But we can also leave it as is and do a find resource later.

patte · 2018-01-04T21:40:39Z

Alright I get it. So let's keep this as is, redirections for documents and users, then add a (find)resource query to republik-backend on top of it for awesome redirection/resolve magic. Because we have many other tasks right now, I'd prefer to postpone that. You agree?

tpreusse · 2018-01-04T21:43:01Z

packages/redirections/migrations/sqls/20180103194546-redirections-up.sql

+  "id"                  uuid primary key not null default uuid_generate_v4(),
+  "source"              text not null,
+  "target"              text not null,
+  "status"              integer not null default 308,


should be 301

only other regular value for redirect is 302

308, strange ;)

tpreusse · 2018-01-04T21:44:02Z

packages/redirections/graphql/schema.js

+}
+
+type queries {
+  # empty response: 404


null is fine for redirect and easier right? resource needs to be 404 ;)

rm docu here—it is returning null and not returning a 404

tpreusse · 2018-01-04T21:45:16Z

packages/redirections/seeds/seeds.example.json

+  {
+    "source": "/me",
+    "target": "/~me",
+    "status": 308


affects: @orbiting/backend-modules-redirections

…eletedAt in get affects: @orbiting/backend-modules-redirections

affects: @orbiting/backend-modules-redirections

tpreusse · 2018-01-07T13:42:58Z

packages/redirections/migrations/sqls/20180103194546-redirections-up.sql

+  "createdAt"           timestamptz default now(),
+  "updatedAt"           timestamptz default now(),
+  "deletedAt"           timestamptz,
+  UNIQUE("source")


not unique with deletedAt

tpreusse · 2018-01-07T13:43:34Z

packages/redirections/graphql/schema.js

+}
+
+type queries {
+  # empty response: 404


rm docu here—it is returning null and not returning a 404

tpreusse · 2018-01-07T13:43:58Z

packages/redirections/lib/Redirections.js

+      redirections
+    WHERE
+      source = :source AND
+      NOT (resource @> :resource) AND


is undefiend handled?

affects: @orbiting/backend-modules-redirections

patte added 3 commits January 4, 2018 01:03

feat(redirections): init backend-modules-redirections

cc15881

affects: @orbiting/backend-modules-redirections

feat(redirections): upsert all redirections with the same ressource

a865b44

affects: @orbiting/backend-modules-redirections

feat(redirections): get redirections by source and resource

83257c0

affects: @orbiting/backend-modules-redirections

tpreusse reviewed Jan 4, 2018

View reviewed changes

patte added 5 commits January 5, 2018 17:04

fix(redirections): add missing DB indices and extensions

9996b60

affects: @orbiting/backend-modules-redirections

fix(redirections): handle cyclic redirections

0715e1d

affects: @orbiting/backend-modules-redirections

fix(upsertRedirections): throw on empty source or target

76adfb2

affects: @orbiting/backend-modules-redirections

feat(redirections): delete redirections, remember deletedAt, filter d…

c2f3ab6

…eletedAt in get affects: @orbiting/backend-modules-redirections

fix(redirections): make 301 the default redirect status code

36e0c5c

affects: @orbiting/backend-modules-redirections

patte force-pushed the redirections branch from 91ea4cf to 36e0c5c Compare January 7, 2018 00:04

patte changed the title ~~wip: redirections~~ redirections Jan 7, 2018

tpreusse reviewed Jan 7, 2018

View reviewed changes

patte added 5 commits January 7, 2018 14:50

fix(redirections): fix deletedAt, cleanup get

78a6898

affects: @orbiting/backend-modules-redirections

fix(redirections): remove comment

da0d8cc

affects: @orbiting/backend-modules-redirections

fix(redirections): add deletedAt to unique contraint

e63e8c1

affects: @orbiting/backend-modules-redirections

fix(redirections): typo

e860402

affects: @orbiting/backend-modules-redirections

fix(redirections): typo

34ad90c

affects: @orbiting/backend-modules-redirections

patte merged commit 8aef262 into master Jan 7, 2018

patte deleted the redirections branch January 7, 2018 16:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

redirections #10

redirections #10

patte commented Jan 4, 2018 •

edited

Loading

patte commented Jan 4, 2018

tpreusse commented Jan 4, 2018 •

edited

Loading

patte commented Jan 4, 2018

tpreusse Jan 4, 2018

tpreusse Jan 4, 2018

patte Jan 6, 2018

tpreusse Jan 4, 2018

tpreusse Jan 7, 2018

tpreusse Jan 4, 2018

tpreusse Jan 7, 2018

tpreusse Jan 7, 2018

tpreusse Jan 7, 2018

redirections #10

redirections #10

Conversation

patte commented Jan 4, 2018 • edited Loading

patte commented Jan 4, 2018

tpreusse commented Jan 4, 2018 • edited Loading

patte commented Jan 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patte commented Jan 4, 2018 •

edited

Loading

tpreusse commented Jan 4, 2018 •

edited

Loading