Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AbortController when available #635

Closed
wants to merge 1 commit into from
Closed

Conversation

tchak
Copy link
Member

@tchak tchak commented May 9, 2019

No description provided.

@dgeb
Copy link
Member

dgeb commented May 20, 2019

This seems promising. AbortController's compatibility is good enough now that we should take advantage of it when available.

Sorry that #630 will require a bit of refactoring.

@tchak
Copy link
Member Author

tchak commented May 22, 2019

I am mostly keeping it as WIP because I need to figure out a proper way of testing it :)

@tchak
Copy link
Member Author

tchak commented Jul 7, 2019

I investigated this a bit more. It will be quite annoying to test with current fetch stubbing setup. @dgeb is there a reason we are not using pretender? It has a decent support for fetch now.

@dgeb
Copy link
Member

dgeb commented Jul 7, 2019

@dgeb is there a reason we are not using pretender? It has a decent support for fetch now.

When I started orbit, this was not true. However, I'd be fine switching to use pretender now if you prefer.

@tchak
Copy link
Member Author

tchak commented Jul 8, 2019

I will need to investigate more. Switching to pretender will require some work and will potentially prevent us from running tests on node, but will make test some fetch options easier. It's a trade-off I am not fully convinced of yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants