Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various small improvements to indexeddb and local-storage sources #689

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Various small improvements to indexeddb and local-storage sources #689

merged 3 commits into from
Sep 13, 2019

Conversation

tchak
Copy link
Member

@tchak tchak commented Sep 8, 2019

No description provided.

@tchak tchak force-pushed the sources-improuvements branch 9 times, most recently from b1db1a9 to 00f9d3b Compare September 12, 2019 13:29
@tchak
Copy link
Member Author

tchak commented Sep 12, 2019

I really don't know what's going on with tests. They timeout. No errors or timeouts in my local setting... I will try to break the PR in smaller ones to check if any particular change is problematic.

@dgeb
Copy link
Member

dgeb commented Sep 12, 2019

@tchak given the changes in this PR, it seems important to ensure that sources are deactivated in the afterEach test hook.

@tchak
Copy link
Member Author

tchak commented Sep 12, 2019

Looks like it must be some changes related to activation

@dgeb dgeb mentioned this pull request Sep 12, 2019
Merged
@dgeb dgeb merged commit e1e621a into orbitjs:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgeb dgeb dgeb approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchak @dgeb