Don't 'replace' isNone value with isNone value #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgeb
added a commit
that referenced
this pull request
Nov 11, 2014
Don't 'replace' isNone value with isNone value
|
@chrisyunker thanks! I created a separate issue (#71) to ensure that we get some tests in place to prevent a regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an environment with two sources connected with bi-directional transform-connectors, if you replace a value with a 'null', it creates an infinite loop. See this for an example: http://jsfiddle.net/chrisyunker/0neso67b/. It also does the same if you replace value with 'undefined'.
Adding another check for this situation in 'transform-connector.transform' is one way to fix this. However, there may be a better way.