Refactor code that deploys into testnet #1094
Conversation
|
@netoneko please review |
|
I've addressed the concerns that @netoneko had with this PR. Preferrably before Thursday if possible :-) |
| @@ -0,0 +1,99 @@ | |||
| #!/usr/bin/env node | |||
|
|
|||
| const { waitUntilSync, getBlockHeight, getCommit } = require('@orbs-network/orbs-nebula/lib/metrics'); | |||
There was a problem hiding this comment.
We decided to unpublish @orbs-network/orbs-nebula a month ago. Why is it used here?
There was a problem hiding this comment.
In your previous review you wanted me to use your code from Nebula
This is the official package. We talked about unpublish (and we did) the other package (orbs-nebula)
This scoped package is the official one which we left
There was a problem hiding this comment.
Official docs still use npm install -g orbs-nebula
Also maybe it would be easier to just install from our github master? We rarely release new nebula version.
| return topology; | ||
| } | ||
|
|
||
| async function eventuallyDeployed({ chainId, nodes }) { |
There was a problem hiding this comment.
waitUnitlCommit from metrics does that already: https://github.com/orbs-network/nebula/blob/master/lib/metrics.js#L112
There was a problem hiding this comment.
I do not agree. I want to see all nodes have updated to the new version. This is not the same.
Your method is single endpoint centric
There was a problem hiding this comment.
You can run it multiple times waiting for the same commit. Same effect, less code.
| "author": "", | ||
| "license": "ISC", | ||
| "dependencies": { | ||
| "@orbs-network/orbs-nebula": "^1.1.2", |
There was a problem hiding this comment.
Should be just orbs-nebula. Also, it's old code, please install from master branch on github.
| @@ -0,0 +1,99 @@ | |||
| #!/usr/bin/env node | |||
|
|
|||
| const { waitUntilSync, getBlockHeight, getCommit } = require('@orbs-network/orbs-nebula/lib/metrics'); | |||
There was a problem hiding this comment.
Official docs still use npm install -g orbs-nebula
Also maybe it would be easier to just install from our github master? We rarely release new nebula version.
| return topology; | ||
| } | ||
|
|
||
| async function eventuallyDeployed({ chainId, nodes }) { |
There was a problem hiding this comment.
You can run it multiple times waiting for the same commit. Same effect, less code.
| }; | ||
| } | ||
|
|
||
| async function eventuallyClosingBlocks({ chainId, nodes }) { |
There was a problem hiding this comment.
Same can be done with nebula call for status, waiting for all of them to become green.
…our testnet deployment. in addition disabled the deployment for now
This PR adds code that deals with deploying into the CI testnet in a manner that follows our approach in recent months of having a centralized S3 bucket that holds information about which virtual chains Boyar should deploy.
The code downloads and modifies the CI's testnet S3 bucket central config and updates the version to deploy for all the chains available there and re-uploads that file into S3.
In addition, the code aims to check that the version was indeed deployed on all provided nodes and that the block height is progressing in all chains. then and only then will the step of deployment to testnet completes successfully and e2e tests can run safely against said chains.
The code also fixes a problem with parsing the nightly junit xml stats as well.