Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add socket timeout option for HTTP requests #40

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

dantrim
Copy link
Contributor

@dantrim dantrim commented Oct 22, 2021

What

This MR adds timeout_sec option to methods that create a socket for performing HTTP requests.

The signatures for the updated methods are such that the default is timeout_sec = 0, which means "no timeout", so any existing code should see no differences.

Related Issues

@orca-zhang
Copy link
Owner

Thanks to you contribution.

The feature is great.
But I think use the type unsigned instead of type const unsigned& could be better.

@dantrim
Copy link
Contributor Author

dantrim commented Nov 13, 2021

Sounds good @orca-zhang. I've changed the time in the latest commits.

@orca-zhang orca-zhang merged commit 77b5b61 into orca-zhang:master Nov 16, 2021
@orca-zhang orca-zhang mentioned this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants