Refresh #12
Merged
Refresh #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grokcode
suggested changes
Nov 3, 2016
| calories = models.FloatField(help_text='Calories for the day') | ||
| activity_calories = models.FloatField( | ||
| help_text='Activity calories for the day') | ||
| distance = models.FloatField(help_text='Distance travelled during the day') |
There was a problem hiding this comment.
@brad It might be helpful to put the units here.
There was a problem hiding this comment.
@grokcode Good call, the documentation doesn't specify but it's probably miles. That would fit well with the examples and it looks like distance on other API end points come in miles.
| user = models.ForeignKey(UserModel, help_text="The device's user") | ||
| device_type = models.CharField( | ||
| max_length=64, | ||
| help_text='The device type. At this time, will always be "shine"') |
There was a problem hiding this comment.
@grokcode Oh, I forgot, thanks!
|
LGTM! Thanks for this update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@orcasgit/orcas-developers Please review. I updated the tox matrix and added docstrings to all the models and
help_texts to all the model fields.