[#118762237] Increase device type max length #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -168,7 +168,7 @@ class Device(MisfitModel): | |||
|
|
|||
| id = models.CharField(max_length=MAX_KEY_LEN, primary_key=True) | |||
| user = models.ForeignKey(UserModel) | |||
| device_type = models.CharField(choices=DEVICE_TYPES, max_length=5) | |||
| device_type = models.CharField(choices=DEVICE_TYPES, max_length=64) | |||
There was a problem hiding this comment.
@percyperez Can we get rid of these choices as well? DEVICE_TYPES isn't an accurate list of possibilities, so it is confusing to keep it around.
There was a problem hiding this comment.
@grokcode good point
|
LGTM 🎸 |
|
Thanks for the human readable migration file name |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@orcasgit/orcas-developers Please review. This should take care of the following warning/messages/error:
Task misfitapp.tasks.import_historical_cls reject requeue=False: value too long for type character varying(5)