Better error handling #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Register compliance hooks so we stop erroneously getting MissingTokenError - Require redirect_uri - Use request-oauthlib auto refresh mechanism, using 'expires_at' - Let request-oauthlib do more of the work in general - Reconfigure some tests to engage the request-oauthlib code
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@orcasgit/orcas-developers Please review. This utilizes the requests-oauthlib library a bit better, enabling auto-refresh if the expires_at attribute has been set, and letting it handle some of the auth headers more. I also enabled a compliance hook that lets requests-oauthlib see the errors in fetch and refresh responses so it will throw the proper exception. There are a few other refactors as well, but it should be entirely backward compatible.