Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the position of the Context Menu as the center when zoom in & zoom out #1035

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

iannbing
Copy link
Contributor

@iannbing iannbing commented Jun 7, 2022

Description

Currently, Zoom in and Zoom out in the Context Menu assume the center point of the canvas as the center.
This PR makes it so that it will zoom in/out precisely with the position of the Context Menu.

Screenshot 2022-06-07 at 17 43 39

This PR also fixes another minor issue:
When zoom in/out with pinching, the speed of zoom in/out is consistent; sometimes it becomes faster and faster (or slower and slower). This PR makes it consistent and smooth.

Checklist

  • The PR branch is set up to merge into dev instead of master.
  • I haven't introduced breaking changes that would disrupt existing jobs, i.e. backwards compatibility is maintained.
  • In case I changed the dependencies in any requirements.in I have run pip-compile to update the corresponding requirements.txt.
  • In case I changed one of the services' models.py I have performed the appropriate database migrations (refer to the DB migration docs).
  • In case I changed code in the orchest-sdk I followed its release checklist.
  • In case I changed code in the orchest-cli I followed its release checklist.

The zoom-in/out should use the position of the context menu as the
center
@iannbing iannbing merged commit bda8fec into dev Jun 8, 2022
@iannbing iannbing deleted the improv/zoom-in-out-issue branch June 8, 2022 08:56
@ricklamers ricklamers added the fix PR fixes a bug label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants