Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflow step logs on resize panel #1426

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

mausworks
Copy link
Member

Description

This PR fixes so that the "logs" output xterm is reflowed when its parent panel is resized.

screen_recording-2022-11-11_16.42.25.mp4

Checklist

  • I have manually tested my changes and I am happy with the result.
  • The PR branch is set up to merge into dev instead of master.

@mausworks mausworks added the fix PR fixes a bug label Nov 11, 2022
@mausworks mausworks temporarily deployed to integration-tests November 11, 2022 15:43 Inactive
@mausworks mausworks temporarily deployed to integration-tests November 11, 2022 15:43 Inactive
@mausworks mausworks temporarily deployed to integration-tests November 11, 2022 15:43 Inactive
@mausworks mausworks changed the base branch from master to dev November 11, 2022 15:44
Copy link
Contributor

@iannbing iannbing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Assigning a state setter to ref is new to me 👍🏻

@cypress
Copy link

cypress bot commented Nov 11, 2022



Test summary

11 0 0 0


Run details

Project orchest
Status Passed
Commit 763fdb4 ℹ️
Started Nov 11, 2022 3:48 PM
Ended Nov 11, 2022 3:50 PM
Duration 01:30 💡
OS Linux Ubuntu - 22.04
Browser Chrome 107

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mausworks
Copy link
Member Author

[...] Assigning a state setter to ref is new to me 👍🏻

A pretty nice trick to know!

@mausworks mausworks merged commit 5c5b6a5 into dev Nov 11, 2022
@mausworks mausworks deleted the fix/ORC-940-reflow-step-logs-on-resize-panel branch November 11, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants