Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter notebook preview export embed images #1448

Merged
merged 10 commits into from
Nov 25, 2022

Conversation

ricklamers
Copy link
Member

Description

Images referred to in markdown need to be rendered in the HTML preview. This enables the embed config option of nbconvert to resolve the path loading issues if images are not embedded.

Checklist

  • I have manually tested my changes and I am happy with the result.
  • The PR branch is set up to merge into dev instead of master.
  • I haven't introduced breaking changes that would disrupt existing jobs, i.e. backwards compatibility is maintained.
  • In case I changed the dependencies in any requirements.in I have run pip-compile to update the corresponding requirements.txt.

@ricklamers
Copy link
Member Author

@fruttasecca we need to go to Flask>=2 to meet the Jinja>=3 requirement for the nbconvert version we need to support embedding images.

We depend on some Flask 1.X only features for flask_script which causes issues when upgrading to Flask>=2.

Traceback (most recent call last):                                                                                                     
  File "/orchest/services/orchest-webserver/app/migration_manager.py", line 2, in <module>                                             
    from flask_script import Manager                                                                                                   
  File "/usr/local/lib/python3.9/site-packages/flask_script/__init__.py", line 15, in <module>                                         
    from flask._compat import text_type                                                                                                
ModuleNotFoundError: No module named 'flask._compat'

Can we refactor flask_script / migration invocation to be able to use Flask>=2?

I'm OK with only doing this for orchest-webserver for the time being. If you'd prefer to also upgrade orchest-api and auth-server to Flask>=2 that would also work for me.

Copy link
Member

@mausworks mausworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

fruttasecca and others added 3 commits November 25, 2022 11:58
This reverts commit cc31061.
Mistakenly introduces some changes to the orchest-api migration
manager.
@ricklamers ricklamers merged commit 0ff76e6 into dev Nov 25, 2022
@ricklamers ricklamers deleted the feat/ipynb-export-embed-images branch November 25, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants