-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter notebook preview export embed images #1448
Conversation
version to get config option.
@fruttasecca we need to go to Flask>=2 to meet the Jinja>=3 requirement for the We depend on some Flask 1.X only features for
Can we refactor I'm OK with only doing this for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
cc06033
to
cc31061
Compare
This reverts commit cc31061. Mistakenly introduces some changes to the orchest-api migration manager.
Description
Images referred to in markdown need to be rendered in the HTML preview. This enables the embed config option of
nbconvert
to resolve the path loading issues if images are not embedded.Checklist
dev
instead ofmaster
.requirements.in
I have runpip-compile
to update the correspondingrequirements.txt
.