Fix job parameter rendering issues #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mausworks
force-pushed
the
fix/ORC-1080-job-parameter-rendering-issues
branch
2 times, most recently
from
3e0278e
to
247f641
Compare
mausworks
force-pushed
the
fix/ORC-1080-job-parameter-rendering-issues
branch
from
247f641
to
6562d88
Compare
Conditionally doing so causes a lot of issues when swapping pipelines/jobs.
iannbing
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes the wrong job parameters show up in the UI: this PR fixes that.
It is a pure rendering problem: the back-end & backing state is fine.
The source of the issue seems to be an optimization to only re-render the form if the pipeline has changed and if any parameters are specified. The problem with that is:
This caused the UI to behave erratically when jumping between jobs & pipelines: displaying the wrong parameters and names.
Checklist
devinstead ofmaster.