Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke scripts with the sh extension using bash #711

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

yannickperrenet
Copy link
Contributor

Description

This adds more functionality to the scripts, without breaking any of the functionality as bash is a superset of sh.

In case you are looking to test it out. The following does work (without any errors) with the given change, but did not work before:

function sayIt {
    echo "I AM SAYING IT"
}

sayIt

The function keyword is not recognized by sh, the sh equivalent would be:

sayIt() {
    echo "I AM SAYING IT"
}

sayIt

This adds more functionality to the scripts, without breaking any of the
functionality as `bash` is a superset of `sh`.
@yannickperrenet yannickperrenet added the improvement An improvement or enhancement to an existing feature. label Feb 11, 2022
@yannickperrenet yannickperrenet merged commit ddaadf3 into dev Feb 11, 2022
@yannickperrenet yannickperrenet deleted the improv/sh-to-bash branch February 11, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An improvement or enhancement to an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant