Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: load testing and gunicorn support #354

Closed
wants to merge 2 commits into from
Closed

Conversation

chicco785
Copy link
Contributor

No description provided.

c0c0n3 added a commit that referenced this pull request Sep 4, 2020
c0c0n3 added a commit that referenced this pull request Sep 4, 2020
@c0c0n3
Copy link
Member

c0c0n3 commented Sep 10, 2020

Just for future reference, the "cleaned up" version of this PR sits in the following commits of the load-test and gunicorn branches

  • port notify load test from WIP: load testing and gunicorn support #354. (a13a8f5) This commit basically lifts the load test as is from this PR and replays it on master.
  • make sure load test uses latest ql code and removes containers to avoid undeletable dangling images. (960a148) This is a small fix to the load test to avoid problems w/ dangling docker images.
  • port gunicorn setup from WIP: load testing and gunicorn support #354. (6b84e35) This commit basically lifts the Gunicorn setup as is from this PR and replays it on master.
  • get rid of supervisord. (4c6f1b1) This is a small improvement over the previous commit since supervisord isn't actually needed. In fact, it'd only monitor the Gunicorn master process which already takes care of monitoring child worker processes. Also Quantum Leap logs were not output to stdout. (This is a consequence of our supervisord config.)

As agreed, we left out the caching stuff, i.e. following changes in this PR

Also notice that there were random failures with the Gunicorn+gevent setup which you can try reproducing by checking out the cleaned up version of commit (6b84e35) mentioned above. Those failures got fixed with the Gunicorn+gthread setup of PR #357 (see 92eb940) and my gut tells me those tests failed for the same reason with the Gunicorn+gevent setup but I had no time to actually verify this.

@c0c0n3 c0c0n3 mentioned this pull request Sep 11, 2020
chicco785 pushed a commit that referenced this pull request Sep 11, 2020
* port notify load test from #354.

* make sure load test uses latest ql code and removes containers to avoid undeletable dangling images.

* port gunicorn setup from #354.

* get rid of supervisord.

* move gunicorn dep to pipfile; flexible wgsi launcher; use gthread instead of gevent; consolidate gunicorn config.

* make test scripts give crate enough time to get 100% functional before starting to hammer it.

* polish gunicorn runner; make config easily overridable in docker container.

* skip broken geocoding test as it has nothing to do w/ this pr.
@chicco785 chicco785 closed this Oct 1, 2020
@chicco785 chicco785 deleted the add-loadl-test branch December 8, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants