Skip to content

Commit

Permalink
Fix/sidenav bugs v2.1.33 (#229)
Browse files Browse the repository at this point in the history
* Updates to sidenav component

* Fixed PR comments

* fixed centering of side nav item icons

* fixed some side nav stuff

* sidenav changes

* popover changes

* updated package with version 2.1.33

* updated package lock

* changed ci workflow to include branch

* fixed link styling and layout

* updated version

* fixed sidenav expanded height issue

* publish new version

* pushed one last change before merging to master

* fixed bug with code

* reverted version and branch changes to ci

* forgot packagelock

* Updates to sidenav component (#222)

* Updates to sidenav component

* Fixed PR comments

* Made some updates to sidenav component (#224)

* fixed mobile layout issue

* SideNav + Popover updates (#225)

* fixed two issues with sidenav

* fixed issue with sidenav height

* another fix for sidenav height

* Upgrade to react 18 (#223)

* Upgrade to react 18

* Fix lint errors

* update packages

* Changes to move storybook to version 7.2

* changes to packages

* removed react-dates

* changes to playroom package

* added react dates with --legacy-peer-deps flag

* Playroom update rolled back

* go back to previous versions

* added legacy deps

* add the new packages back

* fix percy tests

* reverted packages

* add percy cli

* percy yaml file added

* change to percy cli

* updated URL for design system which was pointing to old one

* Fixed storybook orcs design theme (#226)

* Update popover aria values based on element visibility [19.2, 19.3, 19.4] (#212)

* fix(popover): update aria values based on element visibility

* fix(popover): update the button font-size

* fix(popover): add aria-described-by using crypto.randomUUID

* fix(popover): replace crypto.randomUUID with React.useId

---------

Co-authored-by: Adam Bottega <adambottega@gmail.com>

* HELP-6391: fix critical vulnerability (#227)

* HELP-6391: fix outstanding vulnerabilities in ORCS (#228)

* HELP-6391: fix outstanding critical vulnerability that was missed yesterday (somehow)

See https://github.com/orchestrated-io/orcs-design-system/security/dependabot/51

To allow the 'overrides' section of package.json you need Node 16.x and NPM > v8.3
React 18.x means that react-dates is no longer compatible. Use --legacy-peer-deps to install. See react-dates/react-dates#2199

'storybook-deployer' is EOL - see https://github.com/storybook-eol/storybook-deployer

* HELP-6391: migrate to react-number-format 5.x

See https://s-yadav.github.io/react-number-format/docs/migration/

* 3.0.2

* fixed some side nav stuff

* Updates to sidenav component

* sidenav changes

* fixed sidenav expanded height issue

---------

Co-authored-by: Karan Mehta <95593651+KaranAtTeamForm@users.noreply.github.com>
Co-authored-by: Jason T <jason@redant.com.au>
Co-authored-by: Nigel Sheridan-Smith <nigel@greenshoresdigital.com>
Co-authored-by: Nigel Sheridan-Smith <nigel@teamform.co>
  • Loading branch information
5 people committed Sep 12, 2023
1 parent 27cf5ca commit 19e9275
Show file tree
Hide file tree
Showing 2 changed files with 139 additions and 88 deletions.
2 changes: 2 additions & 0 deletions lib/components/SideNav/SideNav.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@ import PropTypes from "prop-types";
import SideNav from ".";
import { BrowserRouter as Router, Route, Link } from "react-router-dom";
import { H5, P } from "../Typography";
import Box from "../Box";

export default {
title: "Components/SideNav",
decorators: [(storyFn) => <Box minHeight="450px">{storyFn()}</Box>],
component: SideNav
};

Expand Down
Loading

0 comments on commit 19e9275

Please sign in to comment.