SideNav + Popover updates #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abottega
added a commit
that referenced
this pull request
Sep 12, 2023
abottega
added a commit
that referenced
this pull request
Sep 12, 2023
* Updates to sidenav component * Fixed PR comments * fixed centering of side nav item icons * fixed some side nav stuff * sidenav changes * popover changes * updated package with version 2.1.33 * updated package lock * changed ci workflow to include branch * fixed link styling and layout * updated version * fixed sidenav expanded height issue * publish new version * pushed one last change before merging to master * fixed bug with code * reverted version and branch changes to ci * forgot packagelock * Updates to sidenav component (#222) * Updates to sidenav component * Fixed PR comments * Made some updates to sidenav component (#224) * fixed mobile layout issue * SideNav + Popover updates (#225) * fixed two issues with sidenav * fixed issue with sidenav height * another fix for sidenav height * Upgrade to react 18 (#223) * Upgrade to react 18 * Fix lint errors * update packages * Changes to move storybook to version 7.2 * changes to packages * removed react-dates * changes to playroom package * added react dates with --legacy-peer-deps flag * Playroom update rolled back * go back to previous versions * added legacy deps * add the new packages back * fix percy tests * reverted packages * add percy cli * percy yaml file added * change to percy cli * updated URL for design system which was pointing to old one * Fixed storybook orcs design theme (#226) * Update popover aria values based on element visibility [19.2, 19.3, 19.4] (#212) * fix(popover): update aria values based on element visibility * fix(popover): update the button font-size * fix(popover): add aria-described-by using crypto.randomUUID * fix(popover): replace crypto.randomUUID with React.useId --------- Co-authored-by: Adam Bottega <adambottega@gmail.com> * HELP-6391: fix critical vulnerability (#227) * HELP-6391: fix outstanding vulnerabilities in ORCS (#228) * HELP-6391: fix outstanding critical vulnerability that was missed yesterday (somehow) See https://github.com/orchestrated-io/orcs-design-system/security/dependabot/51 To allow the 'overrides' section of package.json you need Node 16.x and NPM > v8.3 React 18.x means that react-dates is no longer compatible. Use --legacy-peer-deps to install. See react-dates/react-dates#2199 'storybook-deployer' is EOL - see https://github.com/storybook-eol/storybook-deployer * HELP-6391: migrate to react-number-format 5.x See https://s-yadav.github.io/react-number-format/docs/migration/ * 3.0.2 * fixed some side nav stuff * Updates to sidenav component * sidenav changes * fixed sidenav expanded height issue --------- Co-authored-by: Karan Mehta <95593651+KaranAtTeamForm@users.noreply.github.com> Co-authored-by: Jason T <jason@redant.com.au> Co-authored-by: Nigel Sheridan-Smith <nigel@greenshoresdigital.com> Co-authored-by: Nigel Sheridan-Smith <nigel@teamform.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does, and why