Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TomSelect 1.7 & bootstrap 5 styles doesn't apply to input-group #91

Closed
martinbarilik opened this issue May 18, 2021 · 8 comments
Closed
Labels
bug Something isn't working

Comments

@martinbarilik
Copy link

When using tom-select 1.7 and bootstrap 5 styles, input-group doesn't group the select ( tom-select has radius on both sides )

difference between working and not working down bellow

https://jsfiddle.net/mArtinko5MB/5jo2xc8u/14/

@martinbarilik martinbarilik added the bug Something isn't working label May 18, 2021
@martinbarilik
Copy link
Author

martinbarilik commented May 19, 2021

One small thingy, three cases with input group.

Text / button prepends or appends, or both. In 1.7.1 works only for last case.

https://jsfiddle.net/mArtinko5MB/Lzpv0dys/7/

ps. no idea what's up with fiddle and loading sources, but 1.7.1 is messed up. Works in dev env.

@oyejorge
Copy link
Member

Looks like the problem there is TomSelect not being initialized on a couple examples. Here's an updated example: https://jsfiddle.net/bsae1df7/

new TomSelect('.tom-select'); will only initialize the first DOM node with the .tom-select class.

@martinbarilik
Copy link
Author

Okay, that is one thing.

as i was mentioning

https://jsfiddle.net/mArtinko5MB/rbdcwm86/2/

  • the second example has no radius on the left side, probably missing some styles
  • the selected option has padding top a pixel or two more then needed
  • the more complicated thing is that when you click on select, it fills parent and therefore moves input-group elements to the next row, can we make it the same size whatever we are doing with it ?

@oyejorge
Copy link
Member

the second example has no radius on the left side, probably missing some styles

gotcha. Should be fixed now

the selected option has padding top a pixel or two more then needed

sorry, I'm not seeing it?

the more complicated thing is that when you click on select, it fills parent and therefore moves input-group elements to the next row, can we make it the same size whatever we are doing with it ?

In this situation, I'd probably use the dropdown_input plugin

@martinbarilik
Copy link
Author

image

padding top is causing the issue, it's like a very small space under the text when value is selected

with padding-top and without:

image image

@oyejorge
Copy link
Member

Well, now I know I need to get my eyes checked. It's clear as day now.

@martinbarilik
Copy link
Author

martinbarilik commented May 21, 2021

:D No worries

@oyejorge
Copy link
Member

ok, these should be all set with 1.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants