Change how dropdown_input works to fix #672 and #679 #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 26, 2024 16:36
…f creating a duplicate placeholder input.
|
Changed how focus is handled to fix #660 in the same PR. iOS requires focus to be set within the same input event. Otherwise It won't open the keyboard. So I changed it to be synchronous. Firefox still wants it async, so there is a check for that too. |
|
This pull request has not been active in 120 days and has been marked "stale". Remove stale label or comment or this will be closed in 15 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes dropdown_input to only use one input and keep focus on the input. This way aria-attributes are on the focused element at all times.
This also changes how dropdown_input is styled, using a style more similar to Select2, where focus is still on the control.
Added a test for #672, not sure about how to write a test for #679.