Change text color from #727272 to #595959 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in Issue #1 this is the lightest color for gray text to pass WCAG There are other places on the website where the contrast is not as good, but these problems can be addressed later.
↓ Before ↓↓ After ↓Visually not a big difference, but it is quite significant if you actually read the text. |
|
Thanks for merging this PR, however when I create a site using the generator with the minimal theme it still has the low contrast and the rgb #727272 color. When will you roll out this change to the site generator? |
tooomm
added a commit
to Cockatrice/cockatrice.github.io
that referenced
this pull request
May 7, 2017
lightest color for gray text to pass WCAG (orderedlist/minimal#25)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in Issue #1 this is the lightest color for gray text to pass WCAG
There are other places on the website where the contrast is not as good, but
these problems can be addressed later.