Skip to content

Commit

Permalink
Remove notes
Browse files Browse the repository at this point in the history
  • Loading branch information
casey committed Mar 12, 2024
1 parent bac3149 commit d8e63cb
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 64 deletions.
45 changes: 0 additions & 45 deletions src/subcommand/wallet/etch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,51 +20,6 @@ pub struct Output {
pub transaction: Txid,
}

// todo:
// - use YAML file to describe rune
// - ord wallet etch waits for 6 blocks to broadcast etch
// - add ability to ctrl-c and resume:
// - use nlocktime on etch transaction
// - save commitment in new redb database, wallet.redb
// - save final, signed transaction at original fee rate
// - save enough data to change runestone, fee rate
// - save enough data to abort commitment
// - save original yaml config and check if it changed
// - figure out if there's a way to combine inscribe and etch
//
// todo:
// - test that commits are allowed before activation height
// - test that non-taproot output does not work
// - test that immature output by one block doesn't work
// - test that output that doesn't commit to rune doesn't work
// - test that output with pushbyte with excess bytes works
// - test that unallocated runes are assigned correctly if no runestone
// - fix and test `ord wallet etch`, use nSequence relative
// locktime on etching transaction commit input

// balances::with_runes
// etch::etch_sets_integer_fee_rate_correctly
// etch::inscribe_does_not_select_runic_utxos
// etch::runes_can_be_etched
// etch::send_amount_does_not_select_runic_utxos
// etch::send_inscription_does_not_select_runic_utxos
// etch::send_satpoint_does_not_send_runic_utxos
// etch::trying_to_etch_an_existing_rune_is_an_error
// json_api::get_runes
// json_api::get_runes_balances
// runes::one_rune
// runes::two_runes
// wallet::balance::runic_utxos_are_deducted_from_cardinal
// wallet::send::error_messages_use_spaced_runes
// wallet::send::sending_rune_creates_transaction_with_expected_runestone
// wallet::send::sending_rune_does_not_send_inscription
// wallet::send::sending_rune_leaves_unspent_runes_in_wallet
// wallet::send::sending_rune_with_divisibility_works
// wallet::send::sending_rune_with_excessive_precision_is_an_error
// wallet::send::sending_rune_with_insufficient_balance_is_an_error
// wallet::send::sending_rune_works
// wallet::send::sending_spaced_rune_works

impl Etch {
pub(crate) fn run(self, wallet: Wallet) -> SubcommandResult {
ensure!(
Expand Down
19 changes: 0 additions & 19 deletions src/wallet/inscribe/etch.rs
Original file line number Diff line number Diff line change
@@ -1,24 +1,5 @@
use super::*;

// todo:
// - rename RuneId height and index to block and transaction?
// - todo: use pile in etch ?

// etch::inscribe_does_not_select_runic_utxos
// etch::runes_can_be_etched
// etch::send_amount_does_not_select_runic_utxos
// etch::send_inscription_does_not_select_runic_utxos
// etch::send_satpoint_does_not_send_runic_utxos
// wallet::balance::runic_utxos_are_deducted_from_cardinal
// wallet::send::error_messages_use_spaced_runes
// wallet::send::sending_rune_creates_transaction_with_expected_runestone
// wallet::send::sending_rune_does_not_send_inscription
// wallet::send::sending_rune_leaves_unspent_runes_in_wallet
// wallet::send::sending_rune_with_divisibility_works
// wallet::send::sending_rune_with_insufficient_balance_is_an_error
// wallet::send::sending_rune_works
// wallet::send::sending_spaced_rune_works

#[derive(Deserialize, PartialEq, Debug, Copy, Clone, Default)]
#[serde(deny_unknown_fields)]
pub(crate) struct Etch {
Expand Down

0 comments on commit d8e63cb

Please sign in to comment.