Handle block count RPC error gracefully #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewtoth
force-pushed
the
handle-block-count-error
branch
from
de6c5e3
to
50f2ad7
Compare
This was referenced Feb 16, 2023
Merged
|
I confirm that casey@50f2ad7 on ord 0.5.0 has fixed the time-wasting issue of blocks re-indexing at 775000 every time. |
|
I second @donnlee . My node succeeded on this as well (4GB raspberry pi) |
|
This PR works! |
raphjaph
approved these changes
Feb 21, 2023
|
Hi guys, I have the version 0.5.0 and I still have the issue of indexing: HTTP response too short: length 0, needed 12 What can I do in this case? |
|
@jesuspb2 upgrade to 0.5.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we fail to fetch the block count, it will just return an error from
update_indexwith a JSON-RPC error. However, any uncommitted blocks will not be committed because it doesn't exit the loop. They will have to be indexed again.This PR will just log the error but continue indexing, so we can keep our cache. It will show a progress greater than 100%, but better than having a JSON-RPC error and uncommitted blocks.
The json-rpc client times out and fails if it's not used for a long time, like during a long index update. Since a new client is created to fetch blocks in the background, the
index.clientis not used until near the end, where it already timed out.