Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections not using psbt workflow #1963

Closed
wants to merge 57 commits into from

Conversation

raphjaph
Copy link
Collaborator

No description provided.

raphjaph and others added 30 commits March 1, 2023 19:25
Co-authored-by: ericatallah <eric.atallah@gmail.com>
```
error: Failed to send reveal transaction
because: JSON-RPC error: RPC error response: RpcError { code: -26, message: "non-mandatory-script-verify-flag (Invalid Schnorr signature)", data: None }
```
```
thread 'main' panicked at 'signature hash should compute: PrevoutKind', src/subcommand/wallet/inscribe.rs:360:8
```
reveal TX for inscriptions containing a parent.
Ignore malformed inscriptions.

Co-authored-by: Clarke Benedict <clarke.plumo@gmail.com>
@nammaki nammaki mentioned this pull request Mar 25, 2023
@timechainz
Copy link

@raphjaph You may already be aware but I just wanted to bring to your attention that this branch introduces an inscription numbering inconsistency with master since the child inscriptions are not counted in the current master yet some have already been inscribed.

It looks like this is the first child inscription and where the numbers begin to diverge. 420285
https://ordinals.com/inscription/b884d0e57aea0b1444db21c35b977133f4cdf303dd134a684a3846e06bb73ddci0

@veryordinally
Copy link
Collaborator

veryordinally commented Apr 5, 2023

@raphjaph You may already be aware but I just wanted to bring to your attention that this branch introduces an inscription numbering inconsistency with master since the child inscriptions are not counted in the current master yet some have already been inscribed.

It looks like this is the first child inscription and where the numbers begin to diverge. 420285 https://ordinals.com/inscription/b884d0e57aea0b1444db21c35b977133f4cdf303dd134a684a3846e06bb73ddci0

Yes, see https://github.com/casey/ord/issues/2000 - this is an issue independent of collections. The main branch currently ignored any inscription not on the first input.

@wagmiwiz
Copy link

Hello, just checking if parent/child inscribing is still on the radar?

@veryordinally
Copy link
Collaborator

Yes, very much still on radar. Will resume once the work on cursed inscriptions is finished.

@raphjaph
Copy link
Collaborator Author

raphjaph commented Sep 6, 2023

Merged #2388, #2278 and #2353

@raphjaph raphjaph closed this Sep 6, 2023
@raphjaph raphjaph deleted the collections-no-psbt branch January 31, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants