Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check inscribe destination address network #2189

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Jun 16, 2023

Make sure that inscribe destination addresses are for the correct network.

Fixes #2170.

@ordinals ordinals deleted a comment from Bigdoe41 Jun 18, 2023
@ordinals ordinals deleted a comment from Bigdoe41 Jun 18, 2023
@ordinals ordinals deleted a comment from Bigdoe41 Jun 18, 2023
@casey casey requested a review from raphjaph June 18, 2023 17:18
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@raphjaph raphjaph merged commit 14ff4ba into master Jun 19, 2023
6 checks passed
@raphjaph raphjaph deleted the check-inscribe-address-network branch June 19, 2023 09:51
gmart7t2 added a commit to gmart7t2/ord that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wallet inscribe --destination accepts addresses from other chains
3 participants