Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render GLB/GLTF models in preview #2369

Merged
merged 12 commits into from
Aug 25, 2023
Merged

Render GLB/GLTF models in preview #2369

merged 12 commits into from
Aug 25, 2023

Conversation

raphjaph
Copy link
Collaborator

@raphjaph raphjaph commented Aug 25, 2023 •
edited

casey
casey requested changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. I also think the size needs tweaking, it doesn't look like it fills the preview window.

src/media.rs Outdated Show resolved Hide resolved
src/media.rs Outdated Show resolved Hide resolved
src/subcommand/server.rs Outdated Show resolved Hide resolved
templates/preview-model.html Outdated Show resolved Hide resolved
templates/preview-model.html Outdated Show resolved Hide resolved
casey
casey reviewed Aug 25, 2023
View reviewed changes
src/media.rs Show resolved Hide resolved
casey
casey reviewed Aug 25, 2023
View reviewed changes
templates/preview-model.html Outdated Show resolved Hide resolved
casey
casey reviewed Aug 25, 2023
View reviewed changes
templates/preview-model.html Outdated Show resolved Hide resolved
casey
casey approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphjaph raphjaph enabled auto-merge (squash) August 25, 2023 19:15
@raphjaph raphjaph mentioned this pull request Aug 25, 2023
Closed
@raphjaph raphjaph merged commit c910079 into master Aug 25, 2023
6 checks passed
@raphjaph raphjaph deleted the render-models branch August 25, 2023 19:21
@casey casey mentioned this pull request Aug 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casey casey casey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raphjaph @casey