Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requre --batch or --file for ord wallet inscribe #2581

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Oct 24, 2023

Fixes #2579.

@elocremarc
Copy link
Contributor

elocremarc commented Oct 25, 2023

Can you default it to fallback to file if no flag is specified? This would not cause scripts people made to break that used the old syntax. Keep the commands as backwords as possible would be nice. Because with Ord package manger for instance I am gonna have to determine what version of ord people are running.
https://github.com/cypherpunklab/opm/blob/bcdeb0aa4a86f320334e5d260ea50a38f7da6b8b/utils/inscribe.js#L5

If you stick to --file make sure we also update the docs if we haven't

@casey casey merged commit 7e1ed85 into ordinals:master Oct 25, 2023
6 checks passed
@casey casey deleted the require-batch-or-file branch October 25, 2023 07:01
lglove pushed a commit to lglove/ord that referenced this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error inscribing on testnet
3 participants