Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit reveal #3212

Merged
merged 16 commits into from
Mar 18, 2024
Merged

Commit reveal #3212

merged 16 commits into from
Mar 18, 2024

Conversation

casey
Copy link
Collaborator

@casey casey commented Mar 3, 2024

No description provided.

@casey casey marked this pull request as ready for review March 7, 2024 02:29
@casey casey force-pushed the commit-reveal branch 2 times, most recently from 30c088e to 200f7d2 Compare March 8, 2024 00:32
@casey casey marked this pull request as draft March 12, 2024 21:59
@casey casey force-pushed the commit-reveal branch 2 times, most recently from d8e63cb to da5526d Compare March 12, 2024 22:11
@casey
Copy link
Collaborator Author

casey commented Mar 12, 2024

How should I prevent inscribe creating mixed outputs that contain both runes and inscriptions?

This only happens when the premine is nonzero. If the premine is zero, then you're etching a rune, but not allocating it, so there is no danger of runes landing in the same output as an inscription.

What can we do?

  • If there is already a change output with no inscriptions, then the rune can land there.
  • If there isn't a change output, we can create one, and put the rune there.
  • It should always be possible to append change outputs to an inscribe transaction's outputs after we select inputs and outputs, and not disrupt inscription assignment, so let's do that.

@ordinals ordinals deleted a comment from Morgandri1 Mar 14, 2024
@casey casey marked this pull request as ready for review March 17, 2024 04:40
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@casey casey enabled auto-merge (squash) March 18, 2024 03:16
@casey casey merged commit 55c6094 into ordinals:master Mar 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants