Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert some find tests #571

Merged
merged 6 commits into from
Sep 28, 2022
Merged

Convert some find tests #571

merged 6 commits into from
Sep 28, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Sep 27, 2022

No description provided.

@casey casey marked this pull request as ready for review September 27, 2022 22:56
@casey casey requested a review from raphjaph September 27, 2022 22:57
@casey
Copy link
Collaborator Author

casey commented Sep 27, 2022

I'm not sure if the tests pass, but this is ready for review otherwise. I added a Context struct (we could also call it TestContext if that's clearer) for quickly setting up an Index for unit tests. You might want to rebase your changes on this branch, so you can use it, since it makes the tests much easier to write.

@casey casey changed the title Convert find::second_satoshi Convert some find tests Sep 27, 2022
@casey casey merged commit 2eb8727 into master Sep 28, 2022
@casey casey deleted the convert-find-tests branch September 28, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @raphjaph