Enable CI for Windows #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casey
force-pushed
the
windows-ci
branch
3 times, most recently
from
e56a2b7
to
c12c3af
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was quite surprised to notice a Windows binary on the 0.0.5 release page. Apparently we've been building Windows binaries the whole time, but the build has been failing, so they haven't been appearing on the releases page. However,
redbrecently added Windows support, which must have made them start passing. This PR adds a Windows CI build job. I have no idea if the tests will pass, but if so we can merge this PR and we'll have Windows support.Windows is a pain in the ass, but if we don't have too much work to support it, we should, since a lot of people use it.