refuse to send if other rare ordinals would also be sent to recipient or fee #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t or be consumed by fee
casey
reviewed
Oct 20, 2022
| @@ -45,6 +46,10 @@ impl fmt::Display for Error { | |||
| f, | |||
| "Wallet does not contain enough cardinal UTXOs. Please add additional funds to wallet." | |||
| ), | |||
| Error::AccidentalRareOrdinalSend(ordinal) => write!( | |||
| f, | |||
| "This transaction would also send along Ordinal {ordinal}" | |||
There was a problem hiding this comment.
Suggested change
| "This transaction would also send along Ordinal {ordinal}" | |
| "Cannot perform transaction without sending rare ordinal {ordinal} to recipient or losing it to the fee" |
casey
reviewed
Oct 20, 2022
| @@ -35,6 +35,7 @@ use { | |||
| pub(crate) enum Error { | |||
| NotInWallet(Ordinal), | |||
| NotEnoughCardinalUtxos, | |||
| AccidentalRareOrdinalSend(Ordinal), | |||
There was a problem hiding this comment.
Suggested change
| AccidentalRareOrdinalSend(Ordinal), | |
| CollateralDamage(Ordinal), |
casey
reviewed
Oct 20, 2022
| @@ -45,6 +47,14 @@ impl fmt::Display for Error { | |||
| f, | |||
| "Wallet does not contain enough cardinal UTXOs. Please add additional funds to wallet." | |||
| ), | |||
| Error::RareOrdinalLostToRecipient(ordinal) => write!( | |||
| f, | |||
| "This transaction would also send Rare Ordinal {ordinal} to recipient" | |||
There was a problem hiding this comment.
Suggested change
| "This transaction would also send Rare Ordinal {ordinal} to recipient" | |
| "Transaction would lose rare ordinal {ordinal} to recipient" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t or be consumed by fee