docs: Correct readme for adding benchmark targets manually #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNMoseke
force-pushed
the
docs/correct-readme
branch
from
e78c195
to
e8bba60
Compare
GNMoseke
changed the title
CrownedPhoenix
approved these changes
May 25, 2023
|
Thanks @GNMoseke, will review next week, have a great weekend! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage 71.69% 71.69%
=======================================
Files 26 26
Lines 3433 3433
=======================================
Hits 2461 2461
Misses 972 972 Continue to review full report in Codecov by Sentry.
|
hassila
approved these changes
Jun 1, 2023
|
Thanks for the contribution! |
1 task
hassila
added a commit
that referenced
this pull request
Jun 1, 2023
Fix benchmark init generation to add proper dependencies (as mentioned in (#157)) - fix the local benchmark targets too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small tweak to README to correct adding a plugin to a benchmark target as per the spm docs
How Has This Been Tested?
I've updated my own usage of package-benchmark to the correct
plugins: [...]syntax and confirmed that benchmarks still work as expectedMinimal checklist:
- [ ] I have addedN/ADocCcode-level documentation for any public interfaces exported by the package- [ ] I have added unit and/or integration tests that prove my fix is effective or that my feature worksN/A