Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(major): [sc-6273] remove UnsafeRetained #59

Merged

Conversation

mr-swifter
Copy link
Contributor

Description

Include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

Copy link

This pull request has been linked to Shortcut Story #6273: Move UnsafeRetained to package-data-model.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (478fe06) 83.72% compared to head (68ce1a8) 85.79%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   83.72%   85.79%   +2.07%     
==========================================
  Files          19       17       -2     
  Lines         694      584     -110     
==========================================
- Hits          581      501      -80     
+ Misses        113       83      -30     
Files Coverage Δ
...currencyHelpersTests/ConcurrencyHelpersTests.swift 91.03% <ø> (ø)

... and 1 file with indirect coverage changes

Files Coverage Δ
...currencyHelpersTests/ConcurrencyHelpersTests.swift 91.03% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 478fe06...68ce1a8. Read the comment docs.

@mr-swifter mr-swifter merged commit 5bd22da into main Jan 23, 2024
8 of 12 checks passed
@mr-swifter mr-swifter deleted the feature/sc-6273/move-unsaferetained-to-package-data-model branch January 23, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant