Optimize minimum/1 and maximum/1, per A. Dzahiel's pull request.

oreillymedia · Mar 21, 2013 · 56a67f0 · 56a67f0
1 parent 37e7a7d
commit 56a67f0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1,3 @@
+*.beam
+*~
+
diff --git a/code/ch06-01/stats.erl b/code/ch06-01/stats.erl
@@ -12,7 +12,7 @@
 -spec(minimum(list(number())) -> number()).
 
 minimum(NumberList) ->
-  [Result | Rest] = Numbers,
+  [Result | Rest] = NumberList,
   minimum(Rest, Result).
 
 minimum([], Result) -> Result;

diff --git a/code/ch06-02/stats.erl b/code/ch06-02/stats.erl
@@ -12,7 +12,8 @@
 -spec(minimum(list(number())) -> number()).
 
 minimum(NumberList) ->
-  minimum(NumberList, hd(NumberList)).
+  [Result | Rest] = NumberList,
+  minimum(Rest, Result).
 
 minimum([], Result) -> Result;
 
@@ -28,7 +29,8 @@ minimum([Head|Tail], Result) ->
 -spec(maximum(list(number())) -> number()).
 
 maximum(NumberList) ->
-  maximum(NumberList, hd(NumberList)).
+  [Result | Rest] = NumberList,
+  minimum(Rest, Result).
 
 maximum([], Result) -> Result;
 
@@ -44,4 +46,3 @@ maximum([Head|Tail], Result) ->
 
 range(NumberList) -> [minimum(NumberList), maximum(NumberList)].
 
-