-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add start card rule affecting all heroes. #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the following ruleset.
var guardianCards = new List<Rules.StartCardsModifiedRule.CardConfig>()
{
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Whirlwind, IsReplenishable = true },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Zap, IsReplenishable = false },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.CoinFlip, IsReplenishable = false },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Freeze, IsReplenishable = false },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Fireball, IsReplenishable = false },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.ReplenishArmor, IsReplenishable = true },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Heal, IsReplenishable = false },
};
var hunterCards = new List<Rules.StartCardsModifiedRule.CardConfig>()
{
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.PiercingSpear, IsReplenishable = true },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Zap, IsReplenishable = false },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Speed, IsReplenishable = false },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.HunterArrow, IsReplenishable = false },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Fireball, IsReplenishable = false },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Heal, IsReplenishable = false },
};
var sorcererCards = new List<Rules.StartCardsModifiedRule.CardConfig>()
{
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Whirlwind, IsReplenishable = true },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Zap, IsReplenishable = true },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Fireball, IsReplenishable = false },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Fireball, IsReplenishable = false },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Fireball, IsReplenishable = false },
new Rules.StartCardsModifiedRule.CardConfig() { Card = AbilityKey.Heal, IsReplenishable = false },
};
var startCardRules = new List<Rule>
{
new Rules.StartCardsModifiedRule(new Dictionary<DataKeys.BoardPieceId, List<Rules.StartCardsModifiedRule.CardConfig>>()
{
{ BoardPieceId.HeroGuardian, guardianCards },
{ BoardPieceId.HeroHunter, hunterCards },
{ BoardPieceId.HeroSorcerer, sorcererCards },
}),
};
var startCardRuleset = Ruleset.NewInstance("StartCardRuleset", "New starting hands for Guardian, Hunter and Sorcerer", startCardRules);
registrar.Register(startCardRuleset);
Changes are not having any effect at the moment. I'll see if I can work out why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found the issue that was stopping this working and have pushed another commit with the fix.
Should all be good to merge now.
Resolves #80 .
Note: Haven't gotten around to testing this. Feels like it should work, but can't confirm.
@jimconner In case you happen to want to play with this, feel free to merge if it checks out. Else, I can try to test in the next couple of days.