Skip to content

Commit

Permalink
Bring back the emr_credentials call
Browse files Browse the repository at this point in the history
  • Loading branch information
@orenhe
orenhe committed Mar 10, 2013
1 parent adea261 commit 98eb992
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/wukong/script/emr_command.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def execute_emr_runner
end

command_args << Settings.dashed_flags(:enable_debugging, :step_action, [:emr_runner_verbose, :verbose], [:emr_runner_debug, :debug]).join(' ')
#command_args += emr_credentials
command_args += emr_credentials
command_args += [
"--log-uri=#{log_s3_uri}",
"--stream",
Expand Down

2 comments on commit 98eb992

@Nimster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to change emr_credentials to not add them by default, otherwise it fails if you haven't specified them anywhere (right now the current code works, but if I take your pull request, I will always insert either --credentials or --access-id and --private-key to the command line). So can you also patch emr_credentials function to return nothing if access-id and/or private-key don't exist? Then I will accept this pull.

@orenhe
Copy link
Owner Author

@orenhe orenhe commented on 98eb992 Mar 10, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my use case I always pass --credentials so I didn't see any problem. So, good point. ok.

Please sign in to comment.