Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove extra dependencies and optimize the code #19

Merged

Conversation

olchyk98
Copy link

No description provided.

@olchyk98 olchyk98 force-pushed the handsontable-0.27 branch 5 times, most recently from c778c9a to e6967cc Compare October 26, 2020 13:22
lib/choicesDropdown.js Outdated Show resolved Hide resolved
lib/choicesDropdown.js Outdated Show resolved Hide resolved
lib/choicesDropdown.js Outdated Show resolved Hide resolved
lib/choicesDropdown.js Outdated Show resolved Hide resolved
lib/multi-select.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
web/main.js Outdated Show resolved Hide resolved
web/main.js Outdated Show resolved Hide resolved
web/main.js Outdated Show resolved Hide resolved
lib/choicesDropdown.js Show resolved Hide resolved
lib/choicesDropdown.js Outdated Show resolved Hide resolved
lib/choicesDropdown.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@orestisrodriguez
Copy link
Owner

Few bugs found:

  • When you open a selector with value, then delete those selections, they show up twice in the selection list
  • Select all options and remove them with backpress, a few of them will all be marked as "hovered" state instead of one
  • The selector should take up the whole width of the column

@olchyk98 olchyk98 force-pushed the handsontable-0.27 branch 8 times, most recently from 4b8bb4b to 4d40eb7 Compare November 2, 2020 17:13
@orestisrodriguez orestisrodriguez merged commit 4c3975a into orestisrodriguez:handsontable-0.27 Nov 2, 2020
@orestisrodriguez orestisrodriguez deleted the handsontable-0.27 branch November 2, 2020 17:23
@olchyk98 olchyk98 restored the handsontable-0.27 branch November 3, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants