Disable shadow-rs default features #443
Merged
+2
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes build dependency on libgit2
|
I’m not opposed to merging this, but can you explain a little bit about why you’d like to remove this dependency? It’s only a build time one I’ll fix the CI later as well |
|
For downstream distros packaging gping, it gets tied to libgit2 which most distros prefer to link dynamically rather than having it bundled. So if there's an incompatibility between system libgit2 and the shadow-rs one, it would block updates of gping even though that mismatch is inconsequential. void-linux/void-packages#49676 for some more context. |
|
Ok! I'll fix up the CI and push a new release at the weekend 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes build dependency on libgit2