gping: build against system libgit2 #49676
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
We could alternatively patch Cargo.toml to disable git2 from the shadow-rs crate, especially since there's no git repo to inspect after all. |
|
Those patches get annoying to carry over versions. I sent a patch upstream for now. |
| build_style=cargo | ||
| make_install_args="--path gping" | ||
| hostmakedepends="pkg-config libgit2-devel" | ||
| makedepends="libgit2-devel" |
There was a problem hiding this comment.
if it's just the build script then we need only hostmakedepends
There was a problem hiding this comment.
Tried that, didn't work for cross. It's not only for build, also in main.
|
Drafting for now since patch release is coming upstream in a couple days with removed dep on libgit2. |
Merged
|
ping |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
Although it doesn't actually link against libgit2.so