org-roam-tag-add automatically deletes the double quotation marks of the tags that already exist.

[Imymirror]

I use semicolons to indicate the hierarchy of notes tag.
when tag has semicolon, it will cause an error.

so, I add the double quotation marks.

but, When I try to add a tag using org-roam-tag-add, it automatically removes the double quotes.

[d12frosted]

It seems like a bug to me. Not sure if it's tags formatting or parsing. In any case, tags parsing should be aligned with tags formatting (and vice versa). The quoting of all tags in org-roam-tag-add is intentional to prevent such issues 🤔 😅

[Imymirror]

#1404 not fixes this issue.

I try org-roam-tag-add, it deletes the double quotation marks as before.

[d12frosted]

The problem was not with the removal of quotes, but rather with how org-roam was parsing tags and aliases. We aligned both those paths and now quotes are added and removed automatically when needed.

Do you see erorrs after quotes are removed?

[Imymirror]

Do you see erorrs after quotes are removed?

Yes, when I use org-roam-tag-add add an tag ";category", cause an error.

---

[d12frosted]

🤔 I have updated org-roam before answering you and I see that I can add tags like ;category and org-roam is happy (screenshot from PR):

Can you please check what commit are you on? Did you reload emacs after updating org-roam?

[d12frosted]

And btw, if you are upding from MELPA, you might need to wait for 3-4 hours before it gets available.

[Imymirror]

Can you please check what commit are you on? Did you reload emacs after updating org-roam?

I use doom-emacs.

1. I delete ~/.emacs.d/.local/straight/repos/org-roam
2. ./doom sync
3. restart doom-emacs
4. org-roam-tag-add add an tag ";category", cause an error.

[d12frosted]

Hey, I found another issue - #1406

If you haven't yet updated, I'd rather wait for that to land.

[Imymirror]

If you haven't yet updated, I'd rather wait for that to land.

thank you. I will be here waiting for you.

[d12frosted]

#1406 is merged @Imymirror

I am not using doom emacs, and I already encountered other users who could not update their packages due to doom pinning. For example, I see that by default doom emacs pins org-roam to 15d864a500d90c9dc2e16d888e93343528ec3941. So are you unpinning it?

[Imymirror]

@d12frosted, when i upgrade #1406, it work!

this issue has been solved.

[d12frosted]

Cool. Happy to hear. Sorry for the breakage.