Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edges in graph relating to org-ref cite links #439

Merged
merged 6 commits into from
Apr 12, 2020

Conversation

TimQuelch
Copy link
Contributor

Now that citations appear as backlinks in the backlinks buffer, it makes sense for them to also show
up in the graph.

I'm quite a novice as SQL, so this query probably could have been merged into the previous, but this
works for now.

Motivation for this change

Citation links appear in the backlinks buffer, so they should probably appear in the graph view

Now that citations appear as backlinks in the backlinks buffer, it makes sense for them to also show
up in the graph.

I'm quite a novice as SQL, so this query probably could have been merged into the previous, but this
works for now.
@jethrokuan
Copy link
Member

I agree! Maybe cite links should also get a different color to distinguish them from normal links.

@TimQuelch
Copy link
Contributor Author

I agree! Maybe cite links should also get a different color to distinguish them from normal links.

Agreed. I've added in a configuration variable to control the style. I've set it to default to red for citation links. Could be worth just having a default of black though?

I'm a novice at SQL, so these queries might not be the most efficient/correct, but they seem to be
working on my graphs.
@TimQuelch
Copy link
Contributor Author

I've extended the queries in org-roam-db--conected-component and org-roam-db--links-with-max-distance to ensure that they count citation links as connections.

I'm quite new to SQL, so I'm not sure how efficient/correct these queries are, but they are working on my graphs. Review is welcome on be1329a

@TimQuelch TimQuelch force-pushed the org-ref-links-in-graph branch 2 times, most recently from 4828efa to 9717b1b Compare April 12, 2020 04:27
Copy link
Member

@jethrokuan jethrokuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@jethrokuan jethrokuan merged commit 580a320 into org-roam:master Apr 12, 2020
@TimQuelch TimQuelch deleted the org-ref-links-in-graph branch April 12, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants