opening_hours parser can't parse some "off" cases

[strump]

If "off" day is the first item in opening_hours then it's not parsable by OM.

Case good

E.g. https://www.openstreetmap.org/node/4318534651 → Tu-Su 11:00-01:00; Mo off
Monday is snown as off day:

Case bad

With museum https://www.openstreetmap.org/node/6403156110 → Mo off; Tu-Fr 10:00-19:00; Sa,Su 10:00-14:00
Opening hours are unparsed:

[biodranik]

Isn't it a duplicate?

[strump]

I thought about #1575 but can't tell if it duplicates this issue.

[biodranik]

Interesting, looks like an Android-only bug, because it works on iOS.

[strump]

Interesting, looks like an Android-only bug, because it works on iOS.

@biodranik it’s reproducible on my iPad. Probably caused by 3party/opening_hours code. Where this parsing code came from?

[biodranik]

You're right, this one reproduces on my iPhone too. That code was written by one of the mailru devs. Despite my strong resistance, he chose boost spirit parser. The current implementation takes a lot of time to compile, has bugs, and doesn't parse everything. We even disabled unit tests for it with a plan to come back and fix it when there will be enough time.

[gpesquero]

@strump: Please review PR 7652 and check if we can close this issue.