Replace/refactor the opening_hours library

[RedAuburn]

The current opening_hours implementation can't handle many cases present in OM data. This issue has been opened to centralise discussion on replacement or refactoring of the opening_hours library.

The current implementation is (afaik) a Maps.Me conversion of opening_hours.js to C++.

A replacement library would need to:

1. Be written in C++ for multi-platform support?
2. (please comment/edit with more)

related issues:

• Support Public Holidays in opening times #3883
• BUG : incorrect opening_hours display #5805
• Routing open-hours tests are failing in different timezones #4944
• Sunset/Sunrise open hours displayed incorrectly #4186
• Feature Request: Support Dawn/Dusk Calculation #3457
• Wrong parsing of additive opening_hours ? #3117
• opening_hours with fixed date not parsed #2379
• opening_hours parser can't parse some "off" cases #1612
• [tests] opening_hours_integration_tests, opening_hours_supported_features_tests fails #219

[RedAuburn]

maybe we could generate & store the opening_hours timetable at map generation, instead of at runtime?
for editing, we can just convert to OSM format when submitting the edit

[biodranik]

maybe we could generate & store the opening_hours timetable at map generation, instead of at runtime?

Which timetable do you have in mind? Are you proposing to convert raw strings to something else? What about "advanced" editor?

[biodranik]

The current implementation is (afaik) a Maps.Me conversion of opening_hours.js to C++.

Not exactly. Btw, I can't build the referenced js library. Are there any js => C++ converters?

[map-per]

maybe we could generate & store the opening_hours timetable at map generation, instead of at runtime?

I think that approach would cause problems for complicated opening_hours values like e.g. Mo-Fr 09:00-18:00; 2023 Jun 10-2023 Aug 15 Mo-Fr 09:00-20:00; 2023 Jun 10-2023 Aug 15 Sa 08:00-12:00; PH off (example from the wiki page)

[RedAuburn]

I think that approach would cause problems for complicated opening_hours values like e.g. Mo-Fr 09:00-18:00; 2023 Jun 10-2023 Aug 15 Mo-Fr 09:00-20:00; 2023 Jun 10-2023 Aug 15 Sa 08:00-12:00; PH off (example from the wiki page)

mm, you might be right.. I guess it's worth checking how performant it is to get the current opening_hours status to see if any refactoring is even worth it

[RedAuburn]

Not exactly. Btw, I can't build the referenced js library.

strange, the CI in their git is passing.

Are there any js => C++ converters?

i'm honestly not sure, but it looks like maybe it's not possible :/ https://surma.dev/things/compile-js/

[matheusgomesms]

Does this help? https://github.com/westnordost/osm-opening-hours?tab=readme-ov-file#specification