Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix countries and regions border polygons to fix all related issues #3815

Open
biodranik opened this issue Nov 4, 2022 · 4 comments
Open
Labels
Borders Country borders and polygons Routing Route building issues, e.g. valid route, valid ETA

Comments

@biodranik
Copy link
Member

biodranik commented Nov 4, 2022

All current region borders are located in data/borders in .poly file format. They are used in many places now:

  1. To generate mwm files by cutting the whole Planet file into countries/regions.
  2. To show appropriate "Download ..." dialog on the map.
  3. To route between points
  4. To display address for selected feature
  5. To show address in search
  6. These generated mwms are mapped to the list of downloaded countries in data/countries.txt

The biggest issue is that these polygons should be simplified enough to work fast. And there should be no any holes between nearby polygons, otherwise it is unclear to which region/mwm some point can belong to.

Another issue is that some current borders are outdated.

There are some existing issues related to holes in borders: #511, #729, #857, #1596, #1859, #2156, #3617, #3813, #3827, #8118

There are several possible fixes:

  1. Load all poly borders into some advanced editor and edit nearby regions by removing all holes between them and sharing common edges for different regions/poly files.
  2. Fix our algorithms in different places so if there is a hole, then the nearest region with some downloaded data should be chosen automatically. I see potential issues here, when generator will skip some point/line features which are inside holes.
@biodranik biodranik added the Borders Country borders and polygons label Nov 4, 2022
@biodranik
Copy link
Member Author

For Interstate I-22 it’s 34.210622, -88.187329
For Interstate I-10 it’s 30.474466, -88.400431
Long pressing on either location on the map automatically displays a system error message if you choose either as a starting or ending location.
Note: Not all crossings of the state boundaries creates a system error message. The combined interstates below cross the very same state boundaries line.
For Interstate I-20 & I-59 boundary crossing at 32.448998, -88.403869 it doesn’t doesn’t create a system error message and creates a route just fine.

@biodranik
Copy link
Member Author

Jalisco Mexico puts it as that of Tepic Nayarit

@biodranik
Copy link
Member Author

biodranik commented Sep 12, 2023

Organic Maps, believes the "Jewish Synagogue of Florence"
to be the Province of Massa-Carrara,

while, in fact, it is in Via L. C. Farini: 6, Postcode 5012, Firenze (= Firenze), in the Province of Florence (*)

(*) Note: the title "Province of Florence", abbreviated as "FI", was officially abolished in 2014, and substituted with the more bombastic title of " Città Metropolitana di Firenze" but it is just an invention by bureaucrats, who couldn't find any better pastime; but in the common parlance of us common people, it is still La Provincia di Firenze.

The error is quite serious, and risks to offend to the famous pride of Florentines:

believing that Florence, the capital of the Region of Tuscany, belongs to the Province of
Massa-Carrara,

instead of being the Provincial capital of the Province of Florence (or the Metropolitan city of Florence, in the parlance of bureaucrats since 2014) as it is,

= is like believing that, in Canada, the City of Victoria, the Capital of British Columbia, is in Alberta!

image

@Jean-BaptisteC
Copy link
Member

Another issue #5439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Borders Country borders and polygons Routing Route building issues, e.g. valid route, valid ETA
Projects
None yet
Development

No branches or pull requests

3 participants