Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] routing crash #729

Open
kogelnik opened this issue Jun 25, 2021 · 4 comments
Open

[iOS] routing crash #729

kogelnik opened this issue Jun 25, 2021 · 4 comments
Assignees
Labels
Bug Something isn't working Routing Route building issues, e.g. valid route, valid ETA

Comments

@kogelnik
Copy link

iOS 2021.06.18.1

Routing crash between the points linked below. Crashes for all modes (walking, cycling). Varying the end point nearby can sometimes generate a "system error".

Moving the end point beyond the the gate and routing with car can generate some unusual results, including walking a back to the road to drive a short distance, when the walking solution is much shorter.

https://www.openstreetmap.org/directions?engine=graphhopper_bicycle&route=51.35663%2C-0.29116%3B51.35683%2C-0.29152

@vng
Copy link
Member

vng commented Jun 26, 2021

  • Crash is fixed
  • Car routing doesn't do fallback to pedestrian. It honestly tries to find nearby car roads ..

Root cause here is that start point is put between 2 downloadable regions and doesn't belong to any of them. That happens when region borders are not super high precise.

Expected behaviour here is if the app would say something like "Please, try to move start/end point a bit .."

@biodranik
Copy link
Member

@vng we can also programmatically check and align the borders :)

@rtsisyk rtsisyk added CrashReports Crash Reporting iOS iOS development Routing Route building issues, e.g. valid route, valid ETA labels Jun 26, 2021
@kogelnik
Copy link
Author

@vng
Copy link
Member

vng commented Jul 8, 2021

Well, it's not a crash in updated app version, but "System error" and seems like it's also connected with neighbour regions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Routing Route building issues, e.g. valid route, valid ETA
Projects
None yet
Development

No branches or pull requests

4 participants