Support Public Holidays in opening times

[biodranik]

OM needs:

1. Make sure that PH are properly parsed/supported from OSM (3party/opening_hours)
2. Have manually or automatically updated list of PH (one of the sources can be https://github.com/opening-hours/opening_hours.js/tree/master/src/holidays)
3. Add holidays into data/countries_meta.txt where parsing is already supported, or even better, add holidays into map regions directly in data/countries.txt (and ideally move countries_meta.txt data there).
4. Properly use PH in the code that detects if place is open or closed.

[Misalf-git]

Also, while at it, handling SH (school holidays) in some way might be good. Seems to be pretty much the same thing.

Currently, the presence of SH in the opening_hours tag breaks the formatting for displaying it in the place page, resulting in the raw (rather cryptic) value being shown.

If SH is too uncommon or if its locally differentiating and frequently changing data is not easy to come by, it could still (nicely formatted) be displayed in the place page without evaluation of the current date, in addition to the usual opening hours.

[biodranik]

It may be beneficial to implement a workaround at the first stage: to display OSM values as is, without breaking the UX.

[matkoniecz]

It may be beneficial to implement a workaround at the first stage: to display OSM values as is, without breaking the UX.

based on image in #7372 (comment) - this seem to be done now

[patepelo]

How do you think about first putting Public Holiday as "another day in the week". If the source information contains PH, it translate it to Public Holiday in each language and puts it at the end.

This would be a first step without too complexity.

Also, if later the dates were to be added, some countries like Germany are mapped with that information on its relation. See: https://www.openstreetmap.org/relation/2188155

[patepelo]

Also, the presence of the value "Off" like "Su: off" is very common and should be handled as well.

Then there are more complex cases where the schedules change depending on dates or months. Or even closing time may be "dusk" or such values.

[matkoniecz]

Also, the presence of the value "Off" like "Su: off" is very common and should be handled as well.

Is there a ticket for it?

[patepelo]

Also, the presence of the value "Off" like "Su: off" is very common and should be handled as well.

Is there a ticket for it?

#1575

[biodranik]

I assume that the OH parser code should be rewritten to support these values. As most places follow PH schedule, it may be beneficial to store exceptions instead. Not sure if it's possible.

Using OSM relations as a source of truth doesn't look like a good idea. It should be enough to compile a data file with PHs for each country once a year from public sources. Does anyone do that already?

[matkoniecz]

Does anyone do that already?

https://github.com/opening-hours/opening_hours.js/tree/master/src/holidays

Though from looking at opening-hours/opening_hours.js#456 it is not maintained anymore :(

LGPL licensed, see https://github.com/opening-hours/opening_hours.js/blob/master/package.json#L23

It should be enough to compile a data file with PHs for each country once a year from public sources.

I guess that relations may be also read for that to confirm whether things were missed (though I wonder if quality is good enough to make is worth doing)

[Fxsch]

Is this being worked on? I saw that in Organic Maps a restaurant's opening hours weren't parsed and just being shown as a string, so I thought there was an issue with the data. It was actually just because it had PH in the opening hours and this app can't parse that.