Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt] Migrated on Qt6. #2466

Merged
merged 1 commit into from
Jun 9, 2023
Merged

[qt] Migrated on Qt6. #2466

merged 1 commit into from
Jun 9, 2023

Conversation

vng
Copy link
Member

@vng vng commented Apr 27, 2022

Working app based on Qt6 (no back compatibility with Qt5).

Not necessary to merge right now, for the future.

@vng vng requested a review from biodranik April 27, 2022 13:39
@biodranik
Copy link
Member

I'm not sure if every system already has Qt6 packages available. We need to check with our Linux contributors first before merging it.

@pastk ?

@biodranik
Copy link
Member

You also need to install qt6 in our Linux-check GitHub action. Maybe @pastk can help.

@vng
Copy link
Member Author

vng commented Apr 27, 2022

We need Ubuntu 22. Now we have 20 on GA.

@pastk
Copy link
Contributor

pastk commented May 2, 2022

I'm not sure if every system already has Qt6 packages available. We need to check with our Linux contributors first before merging it.

My distro (Ubuntu 18.04) is quite old, there is no qt6 for it.

@biodranik
Copy link
Member

Paths also should be fixed as in #2565
Don't think that merging it is a good idea, Qt5 is stable, popular and good enough.

@biodranik biodranik closed this May 22, 2022
@biodranik biodranik deleted the vng-qt6 branch May 22, 2022 20:27
@biodranik biodranik restored the vng-qt6 branch May 22, 2022 20:30
@biodranik biodranik reopened this May 22, 2022
@rtsisyk
Copy link
Contributor

rtsisyk commented Jun 10, 2022

homebrew on Mac installs 6.3.0, bot qt5...

@biodranik
Copy link
Member

homebrew on Mac installs 6.3.0, bot qt5...

Bot? brew install qt@5

@rtsisyk rtsisyk self-requested a review October 17, 2022 09:14
@rtsisyk rtsisyk self-assigned this Oct 17, 2022
@vng vng force-pushed the vng-qt6 branch 2 times, most recently from e22d10e to f013f87 Compare November 15, 2022 18:28
@vng
Copy link
Member Author

vng commented Nov 15, 2022

PTAL
See linux-check.yaml, INSTALL.md

@biodranik
Copy link
Member

biodranik commented Nov 15, 2022

RE: scaled icons for Qt5: https://doc.qt.io/qt-5/highdpi.html

On macOS, high-DPI support is enabled by settings in the Info.plist file; so make sure these settings are present.

<key>NSPrincipalClass</key>
<string>NSApplication</string>
<key>NSHighResolutionCapable</key>
<string>True</string>

@vng
Copy link
Member Author

vng commented Nov 16, 2022

@biodranik Of course this settings are already set since 2015 (check qt/res/Info.plist.in).
Here are 2 screenshots with obvious icons rendering quality:
Qt5:
qt5
Qt6:
qt6

@pastk
Copy link
Contributor

pastk commented May 26, 2023

My distro (Ubuntu 18.04) is quite old, there is no qt6 for it.

I found a PPA with QT 6.2 packages for LTS Ubuntu versions as old as 16.04: https://launchpad.net/~savoury1/+archive/ubuntu/qt-6-2
I'll give it a go for Ubuntu 18.04 and report back.

@bam80
Copy link

bam80 commented Jun 2, 2023

@pastk would it be possible for you to try things within next week maybe?
We tried this branch and didn't find notable issues, so we are going to update the documentation and merge this, but after you give us your approval.

@pastk
Copy link
Contributor

pastk commented Jun 8, 2023

I got Qt 6.2.4 on my Ubuntu 18.04. OM desktop builds from this branch and seems to run fine at the first glance (I didn't do extensive testing)!

@vng
Copy link
Member Author

vng commented Jun 8, 2023

Updated branch.
PTAL and merge?

Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
@vng vng merged commit 7c0b0c5 into master Jun 9, 2023
13 checks passed
@vng vng deleted the vng-qt6 branch June 9, 2023 00:13
@bam80
Copy link

bam80 commented Jun 20, 2023

If anyone wanted to test, I've opened PR for adding flathub-beta channel:
flathub/app.organicmaps.desktop#35

@pastk
Copy link
Contributor

pastk commented Jun 22, 2023

Looks like rendering of the map in the release desktop app became slower...
A quick search didn't bring anything like "Qt6 is slower than Qt5", so maybe some default settings had changed?

@bam80
Copy link

bam80 commented Jun 23, 2023

What version did you test? Release is not on Qt6 yet, neither flatpak beta

@biodranik
Copy link
Member

We're working and testing the master branch directly. We noticed that debug version became slower.

@pastk can you please create an issue? It can be a major reason to revert to Qt5 in the worst case and to fix the slow-down root cause in the best case.

@pastk
Copy link
Contributor

pastk commented Jun 24, 2023

We're working and testing the master branch directly. We noticed that debug version became slower.

I've noticed it on a release build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants