-
-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qt] Migrated on Qt6. #2466
[qt] Migrated on Qt6. #2466
Conversation
I'm not sure if every system already has Qt6 packages available. We need to check with our Linux contributors first before merging it. @pastk ? |
You also need to install qt6 in our Linux-check GitHub action. Maybe @pastk can help. |
We need Ubuntu 22. Now we have 20 on GA. |
My distro (Ubuntu 18.04) is quite old, there is no qt6 for it. |
Paths also should be fixed as in #2565 |
homebrew on Mac installs 6.3.0, bot qt5... |
Bot? |
e22d10e
to
f013f87
Compare
PTAL |
RE: scaled icons for Qt5: https://doc.qt.io/qt-5/highdpi.html On macOS, high-DPI support is enabled by settings in the Info.plist file; so make sure these settings are present.
|
@biodranik Of course this settings are already set since 2015 (check qt/res/Info.plist.in). |
I found a PPA with QT 6.2 packages for LTS Ubuntu versions as old as 16.04: https://launchpad.net/~savoury1/+archive/ubuntu/qt-6-2 |
@pastk would it be possible for you to try things within next week maybe? |
I got Qt 6.2.4 on my Ubuntu 18.04. OM desktop builds from this branch and seems to run fine at the first glance (I didn't do extensive testing)! |
Updated branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
If anyone wanted to test, I've opened PR for adding flathub-beta channel: |
Looks like rendering of the map in the release desktop app became slower... |
What version did you test? Release is not on Qt6 yet, neither flatpak beta |
We're working and testing the master branch directly. We noticed that debug version became slower. @pastk can you please create an issue? It can be a major reason to revert to Qt5 in the worst case and to fix the slow-down root cause in the best case. |
I've noticed it on a release build. |
Working app based on Qt6 (no back compatibility with Qt5).
Not necessary to merge right now, for the future.