[Draft] [gpx] Add gpx import #5166

cyber-toad · 2023-05-15T18:58:07Z

Hi,
I try to finish the work started by @dvdmrtnz in #4067.
I made some tests and updated Manifest file but still was not able to have .gpx file associated with OrganicMaps. I asked on stackoverflow and searched on web, but was not able to find an answer.
@rtsisyk @arnaudvergnet - as Android experts could you give me any advice on it?
@biodranik - could you please advice, what minimal set of items is required to be implemented for merge? I checked your comment here #4067 so I think it should be enough to fix codestyle issues that you mentioned and add more tests (what do we want to check - large files, some details of GPX spec, something else)?

Closes #4067
Fixes #2953
Fixes #2681
Fixes #624

Jean-BaptisteC · 2023-05-15T19:49:43Z

For Manifest check this https://stackoverflow.com/questions/3400072/pathpattern-to-match-file-extension-does-not-work-if-a-period-exists-elsewhere-i
I have try debug version, import gpx works, track is correctly show on map 🎉

Tested with track
Tested with 42500 POI in GPX

biodranik

Thanks for your efforts, it's a good start! Let's focus on properly testing and supporting different GPX files/versions and 1.1 spec, and clean the code a bit.

android/jni/app/organicmaps/Framework.cpp

kml/kml_tests/gpx_tests.cpp

kml/serdes_gpx.cpp

kml/serdes_gpx.hpp

map/bookmark_helpers.cpp

map/bookmark_helpers.hpp

map/bookmark_manager.cpp

biodranik · 2023-05-18T06:42:48Z

This file was not imported on iOS

https://www.walkhighlands.co.uk/download.php?w=197

biodranik · 2023-05-18T07:11:12Z

This repo has many samples. Please check if there's something not supported yet: https://github.com/gps-touring/sample-gpx

cyber-toad · 2023-05-18T07:28:31Z

Need to have a look can we implement color support mapped to our current KML

cyber-toad · 2023-05-18T08:02:18Z

This file was not imported on iOS

https://www.walkhighlands.co.uk/download.php?w=197

Checked this one, it is not a recorded track, but a planned route rteType that is not supported for now. I'll check how to support it, added here: https://github.com/cyber-toad/organicmaps/wiki/GPX#todo-for-initial-release

biodranik · 2023-05-18T15:40:54Z

Checked this one, it is not a recorded track, but a planned route rteType that is not supported for now. I'll check how to support it, added here: https://github.com/cyber-toad/organicmaps/wiki/GPX#todo-for-initial-release

It would be great to support it, is it complex?
Please link your issue with our GPX issue. It would be better for other contributors and for us to monitor and fix it, than using your one.

cyber-toad · 2023-05-18T17:25:52Z

1. It would be great to support it, is it complex?

I added support and test in today's commit and I was able to load "Falls of Glomach" route that you mentioned

2. Please link your issue with our GPX issue. It would be better for other contributors and for us to monitor and fix it, than using your one.

I decided just to move this wiki page to comment in #624 issue so it is all together there

biodranik · 2023-05-21T18:23:16Z

If you see that any other related code can be improved by using string_view instead of string, don't stop and fix it :)

kml/serdes_gpx.cpp

cyber-toad · 2023-05-23T19:08:28Z

For Manifest check this https://stackoverflow.com/questions/3400072/pathpattern-to-match-file-extension-does-not-work-if-a-period-exists-elsewhere-i I have try debug version, import gpx works, track is correctly show on map tada

Tested with track Tested with 42500 POI in GPX

I tried couple of suggestions for manifest, but on my Android device I still need to select application for file. Did you test with Android? Was OrganicMaps mapped to .gpx extension in your case?

Jean-BaptisteC · 2023-05-23T19:16:23Z

I store gpx file in root directory, in download directory, i can't open gpx file

biodranik · 2023-05-23T19:36:35Z

I store gpx file in root directory, in download directory, i can't open gpx file

Are KML files opened correctly from the same directory?

Jean-BaptisteC · 2023-05-23T19:43:30Z

Yes i can open kml file from download directory or root directory

biodranik · 2023-05-23T20:19:37Z

Please also check that files with non-ascii symbols and spaces in their names are correctly opened on iOS and Android.

cyber-toad · 2023-05-23T20:46:05Z

Please also check that files with non-ascii symbols and spaces in their names are correctly opened on iOS and Android.

I checked non-ascii and spaces for Android and it is fine, need someone with Apple to help with check for iOS.

cyber-toad · 2023-05-28T07:15:59Z

Just to summarize remaining items because I was not able to have any progress on them

Add file association for Android: I asked on SO, tried the same config as OM has for KML, also checked OSMAnd implementation - but still no luck. I don't know could it be a reason that I deploy OM version from Android Studio - not using GooglePlay
Check non-asci files for iOS - can't do it myself - no iOS device available
Rework file extensions to string_view [Draft] [gpx] Add gpx import #5166 (comment) - I would prefer to look on it separately to avoid increase scope of initial PR

Looks like all other boxes are completed.

biodranik · 2023-05-28T09:25:09Z

(1) is a blocker and should be fixed. However, it looks working on my devices, how did you test it? From which apps did you try to open gpx? On which Android version? Did it fail to suggest Organic Maps open that file type? Does it fail if the app wasn't launched and work if the app was launched at least once?

Please also add GPX mime type scan to getBookmarksFilenameFromUri.

biodranik

Thank you very much! We're almost there :)

android/AndroidManifest.xml

android/jni/app/organicmaps/Framework.cpp

data/gpx_test_data/color.gpx

iphone/Maps/OMaps.plist

kml/kml_tests/CMakeLists.txt

kml/serdes_gpx.cpp

cyber-toad · 2023-05-28T20:52:42Z

(1) is a blocker and should be fixed. However, it looks working on my devices, how did you test it? From which apps did you try to open gpx? On which Android version? Did it fail to suggest Organic Maps open that file type? Does it fail if the app wasn't launched and work if the app was launched at least once?

Please also add GPX mime type scan to getBookmarksFilenameFromUri.

Ok, looks like there is some issue with default Xiaomi Mi file browser. When I try to open a gpx file it always ask me some strange question about file type,

but after I save OM for this file type it starts to open file with OM after I select "Docs" in this dialog. Don't know why Xiaomi asks for file type each time.

I tried in another file browser (Cx File Explorer) and it was fine. It displays list of applications and OM is there. But would be good if we can test on several devices - I have only Xiaomi available, so can only try different file browsers.

getBookmarksFilenameFromUri is fixed, but how I can test it - is it for import of file without extension?

biodranik · 2023-05-28T21:42:52Z

getBookmarksFilenameFromUri is fixed, but how I can test it - is it for the import of files without extension?

This code was written by @rtsisyk , maybe he can give details about testing? I assume it's for cases when the full file name with extension can't be retrieved for some reason, but there is a correct mime type for the file. @rtsisyk do you remember when it is possible and how to test it?

In the worst case, it is a no-op, if a file extension is always available from the system.

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

biodranik · 2023-06-03T21:22:05Z

Ready to merge and release? Are there any issues left to be fixed?

cyber-toad · 2023-06-04T08:58:10Z

Ready to merge and release? Are there any issues left to be fixed?

I tested on my Android with cold start and it worked. There are 3 items that I have difficulties with resolve, for 2 of them I added my comments, for one of them about missing m_org I can't find an answer for now. Additionally 2 comments are displayed as "Outdated", so I can't view them here: https://github.com/organicmaps/organicmaps/pull/5166/files but I think I haven't done anything for them. My other action items are resolved.

biodranik

Please add an exception test in a follow-up pull request. We'll prepare these changes for the release.

biodranik · 2023-06-04T17:01:34Z

And thank you very much for your time and efforts to finish this important task! Do you want us to mention your GitHub nickname (or real name) in our news? @cyber-toad @dvdmrtnz

biodranik · 2023-06-04T18:28:49Z

Let's create an issue for GPX export. It would be great to finish it too.

Jean-BaptisteC · 2023-06-04T18:36:26Z

Done :)

cyber-toad · 2023-06-04T19:08:24Z

And thank you very much for your time and efforts to finish this important task! Do you want us to mention your GitHub nickname (or real name) in our news? @cyber-toad @dvdmrtnz

@biodranik Thanks a lot for your patience and help with this PR, I haven't use C++ for many-many years, so it was not easy for me to work with modern standard. If you want to put any details in news, feel free to use my GitHub handle.I'll try to work on remaining items once I have some free time.

dvdmrtnz · 2023-06-05T10:03:26Z

And thank you very much for your time and efforts to finish this important task! Do you want us to mention your GitHub nickname (or real name) in our news? @cyber-toad @dvdmrtnz

I think @cyber-toad deserves all the credit here! But if you want to mention me too there's no problem!

@cyber-toad Great job!

randomsnowflake · 2023-06-09T12:53:14Z

Great to hear this feature has been implemented! When will he new app hit the iOS App store? I would love to try it out.

biodranik · 2023-06-25T19:59:04Z

@cyber-toad how is time data from gpx stored in kml now after the import?

cyber-toad · 2023-06-27T20:44:12Z

@cyber-toad how does time data from gpx is stored in kml now after the import?

We don't parse datetime data (if you are talking about <time> tag) now. Do we have a place in our internal model for it?

biodranik · 2023-06-28T06:13:49Z

@cyber-toad It will be needed to implement track recording, ideally together with any other custom data. Also, it is useful to display the imported or recorded track statistics.

cyber-toad changed the title ~~[gpx] Add gpx import~~ [Draft] [gpx] Add gpx import May 15, 2023

biodranik reviewed May 15, 2023

View reviewed changes

cyber-toad mentioned this pull request May 18, 2023

Native support of GPX bookmarks to import from OSMand and other apps #624

Closed

cyber-toad force-pushed the gpx branch 2 times, most recently from 1494015 to 2a169ee Compare May 22, 2023 20:43

biodranik reviewed May 23, 2023

View reviewed changes

kml/serdes_gpx.cpp Outdated Show resolved Hide resolved

kml/serdes_gpx.cpp Outdated Show resolved Hide resolved

kml/serdes_gpx.cpp Outdated Show resolved Hide resolved

kml/serdes_gpx.cpp Outdated Show resolved Hide resolved

kml/serdes_gpx.cpp Show resolved Hide resolved

cyber-toad force-pushed the gpx branch from 43b7b32 to d7b273b Compare May 23, 2023 18:52

biodranik requested changes May 28, 2023

View reviewed changes

cyber-toad force-pushed the gpx branch from 1f5279f to ce431cd Compare May 28, 2023 20:03

cyber-toad force-pushed the gpx branch from 3ba156f to ca24272 Compare May 28, 2023 21:00

cyber-toad force-pushed the gpx branch 2 times, most recently from 571c8f5 to 1ffcfc0 Compare May 29, 2023 20:59

cyber-toad added 13 commits June 1, 2023 07:21

[android] Adjust gpx filter

41371eb

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

[gpx] Update test and manifest

9704c79

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

[gpx] Apply code-review suggestions

9024308

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

[gpx] Add basic parser tests for real gpx tracks

dce8961

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

[gpx] Remove unused code, add test for waypoints only

2bfd753

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

[gpx] Support of gpx route (rte/rtept tag)

d66ceee

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

[gpx] Rework parser to use string_view

d7c53e6

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

[gpx] Remove unsupported parameters

e9bab03

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

[gpx] Add support for <color> tag

b01f630

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

[gpx] Fix name/description extraction

ed8207a

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

[gpx] Implement code-review suggestions

8843e70

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

[gpx] Extract track & category names from file name

a567e6e

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

[gpx] Implement code-review suggestions

89d7444

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

cyber-toad force-pushed the gpx branch from fe55f22 to 89d7444 Compare June 1, 2023 05:22

biodranik mentioned this pull request Jun 1, 2023

Use "Bookmarks and Tracks" instead of just "Bookmarks" in the UI #5242

Merged

biodranik approved these changes Jun 4, 2023

View reviewed changes

biodranik merged commit dce7c21 into organicmaps:master Jun 4, 2023
13 checks passed

Jean-BaptisteC mentioned this pull request Jun 4, 2023

GPX format support #4911

Closed

Jean-BaptisteC mentioned this pull request Jun 4, 2023

Add support to export in GPX #5271

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Draft] [gpx] Add gpx import #5166

[Draft] [gpx] Add gpx import #5166

cyber-toad commented May 15, 2023 •

edited by biodranik

Jean-BaptisteC commented May 15, 2023 •

edited

biodranik left a comment

biodranik commented May 18, 2023

biodranik commented May 18, 2023

cyber-toad commented May 18, 2023

cyber-toad commented May 18, 2023 •

edited

biodranik commented May 18, 2023

cyber-toad commented May 18, 2023 •

edited

biodranik commented May 21, 2023

cyber-toad commented May 23, 2023

Jean-BaptisteC commented May 23, 2023

biodranik commented May 23, 2023

Jean-BaptisteC commented May 23, 2023

biodranik commented May 23, 2023

cyber-toad commented May 23, 2023 •

edited

cyber-toad commented May 28, 2023

biodranik commented May 28, 2023

biodranik left a comment

cyber-toad commented May 28, 2023 •

edited

biodranik commented May 28, 2023

biodranik commented Jun 3, 2023

cyber-toad commented Jun 4, 2023 •

edited

biodranik left a comment

biodranik commented Jun 4, 2023 •

edited

biodranik commented Jun 4, 2023

Jean-BaptisteC commented Jun 4, 2023

cyber-toad commented Jun 4, 2023

dvdmrtnz commented Jun 5, 2023

randomsnowflake commented Jun 9, 2023

biodranik commented Jun 25, 2023 •

edited

cyber-toad commented Jun 27, 2023

biodranik commented Jun 28, 2023

[Draft] [gpx] Add gpx import #5166

[Draft] [gpx] Add gpx import #5166

Conversation

cyber-toad commented May 15, 2023 • edited by biodranik

Jean-BaptisteC commented May 15, 2023 • edited

biodranik left a comment

Choose a reason for hiding this comment

biodranik commented May 18, 2023

biodranik commented May 18, 2023

cyber-toad commented May 18, 2023

cyber-toad commented May 18, 2023 • edited

biodranik commented May 18, 2023

cyber-toad commented May 18, 2023 • edited

biodranik commented May 21, 2023

cyber-toad commented May 23, 2023

Jean-BaptisteC commented May 23, 2023

biodranik commented May 23, 2023

Jean-BaptisteC commented May 23, 2023

biodranik commented May 23, 2023

cyber-toad commented May 23, 2023 • edited

cyber-toad commented May 28, 2023

biodranik commented May 28, 2023

biodranik left a comment

Choose a reason for hiding this comment

cyber-toad commented May 28, 2023 • edited

biodranik commented May 28, 2023

biodranik commented Jun 3, 2023

cyber-toad commented Jun 4, 2023 • edited

biodranik left a comment

Choose a reason for hiding this comment

biodranik commented Jun 4, 2023 • edited

biodranik commented Jun 4, 2023

Jean-BaptisteC commented Jun 4, 2023

cyber-toad commented Jun 4, 2023

dvdmrtnz commented Jun 5, 2023

randomsnowflake commented Jun 9, 2023

biodranik commented Jun 25, 2023 • edited

cyber-toad commented Jun 27, 2023

biodranik commented Jun 28, 2023

cyber-toad commented May 15, 2023 •

edited by biodranik

Jean-BaptisteC commented May 15, 2023 •

edited

cyber-toad commented May 18, 2023 •

edited

cyber-toad commented May 18, 2023 •

edited

cyber-toad commented May 23, 2023 •

edited

cyber-toad commented May 28, 2023 •

edited

cyber-toad commented Jun 4, 2023 •

edited

biodranik commented Jun 4, 2023 •

edited

biodranik commented Jun 25, 2023 •

edited